search

501stLegionA3 / FiveOhFirstDataCore

A Web App designed to manage the 501st Legion StarSim Roster.
https://dc.501stlegion-a3.com/
MIT License
8 stars 12 forks source link

AccountCreation accepts same name with different capitalization. #219

Open power-5000 opened 3 years ago

power-5000 commented 3 years ago

Describe the bug

Accepts different Case Nickname

To Reproduce

Steps to reproduce the behavior:

  1. Create a user with a nickname
  2. Create another user with the same nickname but different ID and capitalization of nickname

Notes

Should this be allowed by the software and Checked by Recruiters or coded into the website to check?

power-5000 commented 3 years ago

So we want to check on the website side?

Soyvolon commented 3 years ago

Just add StringComparison.OrdinalIgnoreCase to the .Contains method (iirc that's how it checks for a valid nickname)