search

51st-Vfw / JAFDTC

JAFDTC DTC tool for DCS
GNU General Public License v3.0
0 stars 1 forks source link

A-10C HMCS Page UI Tweaks #42

Closed ilominar closed 6 months ago

ilominar commented 6 months ago

Changed styles to derive from DefaultComboBoxStyle and DefaultTextBoxStyle to preserve default widget shapes.

This fix restores the default rounded TextBlock/ComboBox shapes for consistency. The inheritance in the Styles is no longer as clean as a result, you can thank MSFT for the weird hierarchy. :)

I get the text alignment matches the jet, but after staring at this for a bit, I think I'd group things differently to better align with the rest of the UI. Rather than use indentation to group, maybe additional vertical space to set off groups of related settings? Also, not sure if there's functional meaning of the indentation: for example, setting "Own SPI" to "OFF" disables indented "SPI Indicator" row.

ilominar commented 6 months ago

If there's not much value in the indentation, I'd just right-justify everything to match up with the rest of the UI (and not break related things up with vertical space). Without having a lot of "sub headings" (if you will), the indentation kinda gets lost to me.

No issue with the order.

I'll go ahead and merge this.