search

5HT / fs

📁 FS: Windows, Linux, Mac Driver
https://fs.n2o.dev
Other
235 stars 69 forks source link

initial approach to have possibility to start own supervisor for diff... #18

Closed liveforeverx closed 8 years ago

liveforeverx commented 8 years ago

…erent handlers

It is not thought for merge, but the question, why the interface is so inflexible? If you want to change the path, you need to set environment, before starting the fs application (that leads, that on all places, where library is used, developers simply subscribe to cwd, which is default and checking the needed pattern for the path). And, it is not possible to create more, than one.

I think, there should be interface for it, for creating supervisors in own tree.

Simple attemp to add interface with start_link/4 (which get 3 names and path and it is still ugly), but want to try, that it works.

2 changes, which I want to reach:

What do you think about it in general?

liveforeverx commented 8 years ago

Related to #12

liveforeverx commented 8 years ago

Ok, I've simplified the interface, to set only one name. Than, it should be seen as proposal.

What do you think about?

liveforeverx commented 8 years ago

Added backwards compatibility to original API.

5HT commented 8 years ago

If it works and you'll be ready for catching all possible issues after merge then I can merge your change-set. Did you check that phoenix live reload plugin still works ?

liveforeverx commented 8 years ago

@5HT It works, I have tested and phoenix_live_reload still works. I've added information in README about backwards_compatibility. I'm definitely ready for catching all possible issues. I'm watching now for issues this repository.

5HT commented 8 years ago

Well then thanks and welcome. I'm mergin' and will review code later. We need to remove old code after phoenix_live_reload and active will switch to new schema.