search

649453932 / Chinese-Text-Classification-Pytorch

中文文本分类，TextCNN，TextRNN，FastText，TextRCNN，BiLSTM_Attention，DPCNN，Transformer，基于pytorch，开箱即用。
MIT License
5.25k stars 1.22k forks source link

the while stop condition in DPCNN seems wrong? #45

Closed youyou606 closed 4 years ago

youyou606 commented 4 years ago

https://github.com/649453932/Chinese-Text-Classification-Pytorch/blob/6cb26819af7b646275aff8a4693676f2849e67f6/models/DPCNN.py#L69

Should it be >= 2?

Yumeka999 commented 4 years ago

I think we can use the dpcnn pytorch code of Tencent/NeuralNLP-NeuralClassifier dpcnn_pytorch_code_of_tencent

youyou606 commented 4 years ago

Ok, I will see it