6r1d / minetest_new_glass

New glass mod for the Minetest game
GNU Lesser General Public License v2.1
6 stars 2 forks source link

Suggest not swapping multiple times #12

Closed SwissalpS closed 4 years ago

SwissalpS commented 4 years ago

sorry, I based this on my other PR. cherry-pick or drop as you wish :)

SwissalpS commented 4 years ago

minetest.swap_node() does not trigger any callbacks, so this may be over-thinking it. I was also wondering if there was a particular reason you check for 'reset' last. Shouldn't that be first?