search

86Box / 86Box

Emulator of x86-based machines.
GNU General Public License v2.0
2.79k stars 345 forks source link

Ramfonts does not works on the Hercules Plus. #3529

Closed Fenix770 closed 1 year ago

Fenix770 commented 1 year ago

Describe the bug I tested the Hercules Plus card and installed the Software utilities for it. I found that when I run the ramfont program I only can see the DOS cursor with a black screen.

Here is the HDD image file: 8088 Micoms XL-7.zip

CFG+NVR file: 8088 Micoms XL-7.zip

Hercules Plus drivers: Hercules Graphics Plus Drivers and RAMFont (1986).zip

To Reproduce Steps to reproduce the behavior:

  1. Configure the Vm with Hercules Plus video card
  2. Go to HERCPLUS\RAMFONT subirectory
  3. Run the ramfont utility and choose a font like lcd.fnt

Expected behavior A clear and concise description of what you expected to happen.

Screenshots

Hercules Plus 1

Hercules Plus with ramfont loaded Hercules Plus 2

Same ramfonts (LCD.FNT) with the Hercules In-Color card Hercules In-Color LCD ramfont

Desktop (please complete the following information):

Torinde commented 1 year ago

FYI, Ramfonts were recently implemented in DOSbox-X: joncampbell123/dosbox-x/issues/4139

OBattler commented 1 year ago

It turns out this was already implemented, just incorrectly (the former developer who implemented the Hercules ColorPlus didn't really understand what was supposed to be done), I have now tentatively fixed this now, see if it now works correctly.

Fenix770 commented 1 year ago

The ramfonts now works!. But I found some bugs

Example: HERCULES PLUS RAMFONT

Distorted images on Hercules Plus (CHESS.COM demo program):

HERCULES PLUS distorted image

It seems fixed on the Hercules In-Color card: Hercules in color Chess

The SETMODE.COM utility, which is inside the RAMFONT folder have several options, but it creates a distorted image:

HERCULES UTILITIES

Hercules Plus distorted 2

TC1995 commented 1 year ago

Most likely text mode wraparound issues like when it was in the InColor one.

OBattler commented 1 year ago

Fix committed.

Fenix770 commented 1 year ago

I tested The Hercules Plus again. The chess demo program looks right, but the text cannot be seen. The SETMODE.COM utility still has issues; it creates a distorted text screen.

Hercules Plus

Here I used the SETMODE.COM program and used 8x8 text mode with the 4k ramfont option. Hercules Plus 8x8 4k Ramfont

Fenix770 commented 1 year ago

I also found that if :

  1. I load Norton Commander
  2. I load a Ramfont program and
  3. Then run the diagnostic utility (TEST.BAT),
  4. When I return to DOS prompt the text cannot be seen.

Here is screenshot Hercules plus NC

OBattler commented 1 year ago

I'm quite sure Norton Commander is hardcoded to use 80 columns, so that's not our bug.

As for the fonts disappearing, are you sure that program is for the Hercules Plus and not the Hercules InColor?

Fenix770 commented 1 year ago

I'm almost sure, because the Hercules Plus disk:

1 The timestamp of its files is 1986,

  1. Included the Hercules RAM font mode options program.
  2. Lacks the specific software included on the In-color disks, They are the PALETTE.COM to change the text/graphics colors of the monochrome attributes (2 color for graphics and 4 color for text). and the Write-On utility.

The Hercules In-color card disks:

  1. The timestamp of its files is 1987
  2. Included specific drivers to get 720x348 at 16 colors, (Windows 1.04 and others)
  3. Does not include the Hercules RAM font mode options program.

I downloaded the Hercules Plus drivers from here: https://winworldpc.com/product/hercules-graphics-plus-drivers-and-ramfont/1986.

An the Hercules In-Color from here: http://www.dosdays.co.uk/media/hercules/incolor/hercules_incolor.zip