Some tests fail - Githubissues

8bit-pixies / scikit-feature

GNU General Public License v2.0

32 stars 17 forks source link

Some tests fail #6

Open EricSchles opened 6 years ago

EricSchles commented 6 years ago

Hey,

Going to try to get your tests to pass, might update some of your functions.

looks like the following fail:

trace_ratio
t_score
svm_forward
svm_backward
reliefF
gini
fisher_score
fscore
spec_supervised
spec
rfs
mrmr
mim
mifs
jmi
icap
FCBF
disr
cfs

I'm guessing CIFE also needs to be rewritten (failing on some code I wrote)

EricSchles commented 6 years ago

Okay, it looks like at least part of this is skfeature only accepts matrices for some tests. I'm going to write up some new tests (that are more or less the same) but only use matrices instead of pandas arrays.

And then I'm going to write some examples that show this as well.