search

8bitgentleman / roam-depot-copy-code-block

Roam Research plugin to copy the contents of a code block
MIT License
0 stars 1 forks source link

Console error on copy, both inline and block #5

Closed cori closed 5 months ago

cori commented 1 year ago

This morning I started seeing this error in the console in both Brave and Arc

1fe36c97-27ba-4932-8540-ebc57469db01:2 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading '2')
    at HTMLSpanElement.i (1fe36c97-27ba-4932-8…ebc57469db01:2:9320)

(this is from inline - it changes to reading '6' when copying a block)

TBQH it's been a while since I've used the functionality, so I have no idea when this may have started.

OS: macOS Ventura 13.4 Arc: Version 0.106.1 (39259) Chromium Engine Version 114.0.5735.45 Brave: [Version 1.52.117 Chromium: 114.0.5735.90 (Official Build) (arm64)](https://brave.com/latest/)

I'll try on some other browser when I can.

8bitgentleman commented 1 year ago

hmm I'll look into this, Does the extension still work for you?

cori commented 1 year ago

hey sorry for the delay - it does not. I see the same error in Safari as well.

buildaworld commented 6 months ago

It has been a long time.

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading '2')

8bitgentleman commented 6 months ago

Long enough I'd say, the fix for this has been submitted to Roam for review. You can follow the pull request here

8bitgentleman commented 5 months ago

This fix is now live in Roam Depot!

cori commented 5 months ago

LGTM! Thanks so much!