8xFF / atm0s-media-server

Decentralized, Global-Scale Media Server written in Rust (WebRTC/Whip/Whep/Rtmp/Sip)
https://8xff.github.io/media-docs/
MIT License
211 stars 17 forks source link

Fix build warnings and clippy warnings #328

Closed dhilipsiva closed 1 month ago

dhilipsiva commented 1 month ago

Pull Request

Fix Cargo Build Warning and Clippy Warnings

Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 65.78947% with 52 lines in your changes missing coverage. Please review.

Project coverage is 43.82%. Comparing base (c459b13) to head (324c3ba).

Files Patch % Lines
packages/transport_webrtc/src/transport/webrtc.rs 0.00% 14 Missing :warning:
packages/media_connector/src/agent_service.rs 0.00% 6 Missing :warning:
packages/media_connector/src/handler_service.rs 0.00% 6 Missing :warning:
...rnal/local_track/packet_selector/video_h264_sim.rs 78.26% 5 Missing :warning:
...ernal/local_track/packet_selector/video_vp9_svc.rs 86.48% 5 Missing :warning:
packages/media_gateway/src/agent_service.rs 0.00% 5 Missing :warning:
...ernal/local_track/packet_selector/video_vp8_sim.rs 90.69% 4 Missing :warning:
...s/media_core/src/endpoint/internal/remote_track.rs 0.00% 2 Missing :warning:
bin/src/http/api_console.rs 0.00% 1 Missing :warning:
bin/src/server/connector.rs 0.00% 1 Missing :warning:
... and 3 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #328 +/- ## ========================================== - Coverage 43.89% 43.82% -0.07% ========================================== Files 117 117 Lines 12984 12982 -2 ========================================== - Hits 5699 5690 -9 - Misses 7285 7292 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dhilipsiva commented 1 month ago

@giangndm Thank you for your response. I have addressed all your questions. Please let me know if you have more questions or feedbacks.

dhilipsiva commented 1 month ago

@giangndm I have updated the code as per your feedbacks. Please let me know if I need to do more changes.