Closed dhilipsiva closed 1 month ago
Attention: Patch coverage is 85.71429%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 41.61%. Comparing base (
da3d144
) to head (814b14c
).
Files | Patch % | Lines |
---|---|---|
packages/media_utils/src/f16.rs | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@giangndm Can you please delete the 94MB Cache from here?
https://github.com/8xFF/atm0s-media-server/actions/caches
Duplicate cache got created because of workflow race condition
@dhilipsiva I just clear all caches.
@giangndm Do you want me to make anymore changes on this?
Clippy was already being used. But it never reported any problems. The errors were always suppressed because we were piping the clippy output to cargo-sarif. This piping masked the exit code of clippy command. Which is why you might notice clippy is run twice now.
Note: actions-rs was deprecated and archived because GH Actions now support for rust by default: https://github.com/actions/starter-workflows/blob/main/ci/rust.yml
Apart from this, I have also added a cargo fmt action, added cache support and fixed remaining clippy warnings.
CC: @giangndm: https://github.com/8xFF/atm0s-media-server/pull/349#issuecomment-2232288594
Checklist