8xFF / atm0s-media-server

Decentralized, Global-Scale Media Server written in Rust (WebRTC/Whip/Whep/Rtmp/Sip)
https://8xff.github.io/media-docs/
MIT License
212 stars 17 forks source link

ci: fix clippy actions workflow and add cargo-fmt action #353

Closed dhilipsiva closed 1 month ago

dhilipsiva commented 1 month ago

Clippy was already being used. But it never reported any problems. The errors were always suppressed because we were piping the clippy output to cargo-sarif. This piping masked the exit code of clippy command. Which is why you might notice clippy is run twice now.

Note: actions-rs was deprecated and archived because GH Actions now support for rust by default: https://github.com/actions/starter-workflows/blob/main/ci/rust.yml

Apart from this, I have also added a cargo fmt action, added cache support and fixed remaining clippy warnings.

CC: @giangndm: https://github.com/8xFF/atm0s-media-server/pull/349#issuecomment-2232288594

Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.61%. Comparing base (da3d144) to head (814b14c).

Files Patch % Lines
packages/media_utils/src/f16.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #353 +/- ## ========================================== - Coverage 41.62% 41.61% -0.01% ========================================== Files 134 134 Lines 14120 14120 ========================================== - Hits 5877 5876 -1 - Misses 8243 8244 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dhilipsiva commented 1 month ago

@giangndm Can you please delete the 94MB Cache from here?

https://github.com/8xFF/atm0s-media-server/actions/caches

Duplicate cache got created because of workflow race condition

giangndm commented 1 month ago

@dhilipsiva I just clear all caches.

dhilipsiva commented 1 month ago

@giangndm Do you want me to make anymore changes on this?