8xFF / atm0s-media-server

Decentralized, Global-Scale Media Server written in Rust (WebRTC/Whip/Whep/Rtmp/Sip)
https://8xff.github.io/media-docs/
MIT License
233 stars 17 forks source link

fix: endpoint internal clean up crash #447

Closed giangndm closed 3 weeks ago

giangndm commented 1 month ago

Pull Request

Description

This PR fix https://github.com/8xFF/atm0s-media-server/issues/440

Related Issue

If this pull request is related to any issue, please mention it here.

Checklist

Screenshots

If applicable, add screenshots to help explain the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 46.66667% with 232 lines in your changes missing coverage. Please review.

Project coverage is 41.51%. Comparing base (4746d6b) to head (3c26709). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...s/media_core/src/endpoint/internal/remote_track.rs 46.43% 173 Missing :warning:
bin/src/http.rs 0.00% 32 Missing :warning:
packages/media_core/src/endpoint/internal.rs 35.29% 11 Missing :warning:
bin/src/http/api_metrics.rs 0.00% 4 Missing :warning:
packages/media_utils/src/count.rs 90.00% 4 Missing :warning:
bin/src/server/media.rs 0.00% 3 Missing :warning:
packages/transport_rtpengine/src/transport.rs 0.00% 2 Missing :warning:
packages/media_core/src/endpoint.rs 0.00% 1 Missing :warning:
...es/media_core/src/endpoint/internal/local_track.rs 0.00% 1 Missing :warning:
packages/transport_webrtc/src/transport.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #447 +/- ## ========================================== + Coverage 41.37% 41.51% +0.13% ========================================== Files 165 167 +2 Lines 18154 18460 +306 ========================================== + Hits 7512 7664 +152 - Misses 10642 10796 +154 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.