-
Hi I stumbled upon your project and even though I'm not into chemistry it looks interesting :)
I've used a Python tool/framework called Plotly Dash for creating data-driven dashboards for several p…
-
I would suggest excluding for loops when handling operations on arrays.
https://github.com/facg3/chemics/blob/170e4ac80db74d357b1ad59a5d5867ae88b35a90/public/script.js#L13
and in:
https://github.co…
-
in: (script.js)
it seems like you really need to handle xhr request errors that may occur, it should be inside this block,
https://github.com/facg3/chemics/blob/170e4ac80db74d357b1ad59a5d5867ae88b…
-
> this is copied from https://github.com/facg3/chemics/issues/9
With any project, but especially one with a server, it's nice to have some instructions in the readme of how to run the project local…
-
## Describe the bug
When compiling with -DCHEM_DBG_[I,J,K], several compiletime errors occur:
### 1. chem/module_optical_averaging.F:4356
- Rank mismatch, swrefindx_col is rank 3, but write calls…
lpilz updated
3 years ago
-
In this line
https://github.com/facg3/chemics/blob/cc6da16a2f605969bfaababa5abc402954321073/src/router.js#L26
you guys are using for loop with var which can cause a lot of problems in scoping if t…
-
https://github.com/facg3/chemics/blob/cc6da16a2f605969bfaababa5abc402954321073/src/router.js#L35
you are returning html if there was an error, and json if it success.
and also the `content-type`…
-
in the `/chemics` route you are finding matches in your `.json` file, and breaking when you have 7 results.
You both push to the `ret` array and increment `limit` at the same time. You could repla…
-
Hey! I'm submitting this fake issue per our prior conversation. If you submit this to JOSS one day, feel free to ping me (or suggest me as a reviewer directly). Would be happy to review this.
Nice …
-
Hello, I have found some literatures on Cp and enthalpy of chemical substances (because there is a little big difference between Cp and enthalpy of BioSTEAM and Aspen). I still have the following ques…