-
[SonarCloud](https://sonarcloud.io/) is a useful tool which can tell us vulnerabilities and improve code quality
See this issue
- https://github.com/cosmos/interchain-security/issues/171
This…
danwt updated
2 years ago
-
The default consumer `app.go`, i.e., `app/consumer/app.go`, should contain only the modules necessary for the minimum viable consumer chain:
- Staking module is disabled
- Governance module is disab…
mpoke updated
2 years ago
-
In general, there are instance of converting non string types to bytes using `fmt.Sprintf` concatenated with '/' and then reintepreting those bytes later by splitting on '/'. This is flawed because no…
danwt updated
2 years ago
-
During the initialization period, the consumer chain has the same initial validator set `V1`. To keep the security model of Tendermint, **none of the validators in `V1` should be able to unbond any am…
mpoke updated
2 years ago
-
At 80d146a02b0b7631a01cd40f026e6609ccb2f3d9 the CI tests fail on github
danwt updated
2 years ago
-
ref.
- https://github.com/cosmos/interchain-security/pull/118#discussion_r887888264
> what happens theoretically if the unbonding is put on hold while child chains exist, but then child chain g…
mpoke updated
2 years ago
-
In `validatorUnbondingCanComplete` the following code
```go
func (k Keeper) validatorUnbondingCanComplete(ctx sdk.Context, id uint64) (found bool, err error) {
val, found := k.GetValidatorByUnbo…
danwt updated
2 years ago
-
Currently, the integration tests are failing because the distribution module beginblocker is crashing, because the distribution module needs to be disabled on consumer chains. This would be permanentl…
-
# Idea
A reference implementation will be needed for [differential testing](https://github.com/cosmos/interchain-security/issues/60). For the first application of differential testing the implement…
danwt updated
2 years ago
-
#225 implements changes necessary for gosec tests to pass. One such change is no longer ignoring the error that is returned from [UnbondMaturePackets](https://github.com/cosmos/interchain-security/blo…