ACCESS-NRI / model-config-tests

Tests for checking model configurations
Apache License 2.0
0 stars 1 forks source link

ACCESS-ESM1.5 QA test: CICE icefields_nml configuration #54

Closed jo-basevi closed 3 months ago

jo-basevi commented 3 months ago

Added QA test for separate icefields_nml in ice_history.nml (in as described in #50)

Closes #50 Closes #44

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.07%. Comparing base (2d538a5) to head (0e91aec). Report is 15 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #54 +/- ## ========================================== + Coverage 73.48% 78.07% +4.59% ========================================== Files 15 15 Lines 724 748 +24 ========================================== + Hits 532 584 +52 + Misses 192 164 -28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jo-basevi commented 3 months ago

I quickly added a generic test for the ACCESS-ESM1.5 specific config tests - to just checking the tests pass without error (and also to pass the codecov CI checks..)

I ran some manual tests with an configuration to test the error messages, and that they failed when expected

jo-basevi commented 3 months ago

It seems like there are three things bundled into one PR here ?

Yes, sorry about that! I added the tests so they covered the lines I added in the first commit. But yeah next time, I'll add the wider tests for tests in an earlier PR.

CodeGat commented 3 months ago

This should also close #44

jo-basevi commented 3 months ago

Thanks all for the reviews!