search

ACCESS-NRI / spack-packages

Spack package repository maintained by ACCESS-NRI
Apache License 2.0
5 stars 4 forks source link

Check for correct URL for public vs private repos #159

Open aidanheerdegen opened 2 weeks ago

aidanheerdegen commented 2 weeks ago

Private GitHub repos should use git@github.com:org/repo.git URLs, whereas https URLs are preferred for public repos.

This was highlighted in this issue

https://github.com/ACCESS-NRI/spack-packages/pull/155

which broke automated CI style builds that rely on SSH keys to access a private repo.

It should be possible to add a CI QA test to check the code URLs and make sure https is used for public GitHub repos, and git URLs for private.

penguian commented 2 weeks ago

See in partcular issue #158 which asks to revert pull request #155