search

ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.
https://phoenix.acinq.co
Apache License 2.0
679 stars 98 forks source link

Prefer BIP353 over LNURL if found #589

Closed Sjors closed 4 months ago

Sjors commented 4 months ago

Or at least, it would be nice to have this configurable.

Right now for sjors@sprovoost.nl it finds my NLURL instead of bolt12.

This was with iOs app version 2.3.0. It can pay to the (CLN generated) offer just fine if I paste it directly.

BIP353 has better privacy properties for the sender, so in the long run it should be preferred. But it's still new.

dpad85 commented 4 months ago

This was with iOs app version 2.3.0.

You'll have to upgrade to version 2.3.1 -- the previous version can pay offers, but has no understanding of BIP353 and always tries to pay email-like address through the LNURL flow.

BIP353 is supported on Android 2.3.3+ and iOS 2.3.1+, and indeed Phoenix will always try BIP353 first, and will only fallback to LNURL if BIP353 fails. Though we should also have an option (opt-in) somewhere to never fallback to LNURL.

Sjors commented 4 months ago

Ahh I tried too soon :-)

v2.3.1 iOs update appeared this morning for me!

Will let you know if doesn't work as expected.