search

ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.
https://phoenix.acinq.co
Apache License 2.0
682 stars 98 forks source link

Typing "email" address support #590

Open Sjors opened 4 months ago

Sjors commented 4 months ago

Typing an email / lightning / bip353 address right in the app is often more convenient than having to scan or paste it. I find myself typing it in another app and then pasting it.

Sjors commented 4 months ago

(and it should probably track recipients so you can send them money again, but that's potentially much more involved)

dpad85 commented 4 months ago

The "send" view is going to be reworked. It was designed around a bolt11 payment flow where most of the time you had to scan a QR code to do anything.

But now, with static payment instructions becoming more prevalent, that screen should be designed around a contacts/recent payments UI + a free form text input. There will still be a button somewhere to open the scanner but it should not be the default.

@robbiehanson that will be a good opportunity to rework the ScanController class, maybe remove the MVI pattern as well.

notmandatory commented 3 months ago

I've been playing with the "Contacts" feature and it would be nice to be able to add a lno offer to my contact list using someone's bip353 address also.

Sjors commented 3 months ago

@notmandatory I think you can now save it when you send the first time.

notmandatory commented 3 months ago

@Sjors thanks for the tip! I tired it (iOS/v2.3.2) and when I manually input the bip-353 lno address I was given a little button to add that address to a new contact in my contacts. I also confirmed that if I manually enter the address for an existing contact that the payment screen detects that and shows me the contacts name on the confirm payments screen.