iOS: Share invoices lowercased

ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.

https://phoenix.acinq.co

Apache License 2.0

679 stars 98 forks source link

iOS: Share invoices lowercased #604

Closed evansmj closed 3 months ago

evansmj commented 4 months ago

According to BIP-0173, for presentation, lowercase invoices are preferable. The QRCodes are correctly encoded as uppercase here, but the text is also pasted as uppercase. Android copies the text as lowercase and since presentation is preferred to be lowercase I set the text to lowercase here.

Issue: https://github.com/ACINQ/phoenix/issues/601

robbiehanson commented 3 months ago

Good find and good fix.

Notes: This PR will cause conflicts with #602, which is almost ready to be merged. I can circle back and patch this PR after 602 is merged.

robbiehanson commented 3 months ago

superseded by #610