search

ACM-BITS-Pilani-Goa / OfficialWebsite

Official website of ACM BITS Pilani Goa Chapter
https://bitsg.acm.org/
MIT License
3 stars 5 forks source link

Create navbar #75

Closed AmirNaghibi closed 2 years ago

AmirNaghibi commented 2 years ago

Updating Website Header

Desktop View

Screen Shot 2021-10-11 at 10 12 44 PM

Mobile View

Screen Shot 2021-10-11 at 10 16 08 PM

Screen Shot 2021-10-11 at 10 16 21 PM

🔻 Note: Subscribe here link in https://bitsg.acm.org/events will go to a page where permission is needed. The link needs to be updated. (created an issue: #74 )

Screen Shot 2021-10-11 at 10 19 05 PM

Addressing Issue: #68

Devesh21700Kumar commented 2 years ago

Updating Website Header

Desktop View

Screen Shot 2021-10-11 at 10 12 44 PM

Mobile View

Screen Shot 2021-10-11 at 10 16 08 PM

Screen Shot 2021-10-11 at 10 16 21 PM

🔻 Note: Subscribe here link in https://bitsg.acm.org/events will go to a page where permission is needed. The link needs to be updated. (created an issue: #74 )

Screen Shot 2021-10-11 at 10 19 05 PM

Addressing Issue: #68

The PR looks good to me. Great work and thanks !!

1).I do feel that here image This subscribe to news letter could have been be centered a bit more.

2).Regarding the wiki link , its opening without any 404 errors.

3).And as far as issue #74 is concerned, the form presently is made available to only our university students. Maybe that's why its asking you for permission.

AmirNaghibi commented 2 years ago

Thank you for the feedback. I'll look into it and update the PR soon :)

Aviral09 commented 2 years ago

@AmirNaghibi Please resolve merge conflicts and update your PR.

AmirNaghibi commented 2 years ago

Thanks for the reminder. Unfortunately, I won't be able to work on this anymore due to other priorities.

Feel free to make the issue open again. The change should be minimal as most of the header features is in the PR.

Aviral09 commented 2 years ago

No worries. Closing PR.