search

ACRA / acra-storage

GNU General Public License v3.0
49 stars 31 forks source link

Escape backslashes in js string so they are part of RegEx #5

Closed davcamer closed 10 years ago

davcamer commented 10 years ago

The change from // style regex to new RegExp missed a subtle change. Because new RegExp takes a javascript string as a parameter, the backslashes need to be escaped so that they survive in to the string, and then serve to escape the outer "()"s there. You can see the problem with the current version in littleguy77's test data: https://paulscode.iriscouch.com/acralyzer-custom/_design/acralyzer/index.html#/reports-browser/mupen64plusae

The signature.digest and signature.full fields are nearly identical. But, I think the intention was to capture only the filename for signature.digest.

KevinGaudin commented 10 years ago

Thanks for noticing this. Upgrading to this new version will bring old bugs as new though... sorry 'bout that.