ACRA / acra

Application Crash Reports for Android
https://www.acra.ch
Apache License 2.0
6.32k stars 1.14k forks source link

Add a note about `ReportSenderException` #1362

Closed GregCornis closed 3 months ago

GregCornis commented 5 months ago

acra-http throws a ReportSenderException if it fails to send the report, so I imagine it's a mechanism to allow for a later retry. ACRA's message is pretty clear: org.acra.sender.ReportSenderException: Policy marked this task as incomplete. ACRA will try to send this report again.

I thought it would be nice to document it. It might need to be rephrased.

F43nd1r commented 5 months ago

Depending on the RetryPolicy, the sentence you added might not be true. Default behaviour is to only retry when all senders failed. Of course most setups will only use one sender and the default policy, in which case your statement is true.

GregCornis commented 5 months ago

How about

You can implement your own ReportSender and configure ACRA to use that instead of or in addition to other senders. Note: Throwing a ReportSenderException from YourCustomSender.send() notifies ACRA of a failed delivery, and might trigger a retry (see RetryPolicy).