ADAPT / Standard

ADAPT Standard data model issue management
https://adaptstandard.org
MIT License
8 stars 1 forks source link

Does Data Type Representation indeed need a Version? #108

Open knelson-farmbeltnorth opened 1 year ago

knelson-farmbeltnorth commented 1 year ago

Version requires that any id of a Representation is compound, with Code & Version. Do we intend to version the codes often enough to make the complexity worthwhile?

knelson-farmbeltnorth commented 1 year ago

@zwing99 has proposed that we version the entire collection of Representations using semantic versioning. As such, we would carry a single Representation version number across the entire Application Data Model. Data consumers would simply reference the appropriate version of the codes. As such, we could remove the version from each Representatation. @strhea and I like the solution. @aferreyra what are your thoughts?

zwing99 commented 1 year ago

@zwing99 has proposed that we version the entire collection of Representations using semantic versioning. As such, we would carry a single Representation version number across the entire Application Data Model. Data consumers would simply reference the appropriate version of the codes. As such, we could remove the version from each Representatation. @strhea and I like the solution. @aferreyra what are your thoughts?

Yes, please version them as one!

aferreyra commented 1 year ago

I think it’s fine to version the whole thing. I assume an API implementation will have a ModDate on each entry to facilitate synchronization.

Thanks,

Andres

Get Outlook for iOShttps://aka.ms/o0ukef


From: Zac Oler @.> Sent: Wednesday, September 20, 2023 11:33:27 AM To: ADAPT/Standard @.> Cc: Ferreyra Andres USRS @.>; Mention @.> Subject: Re: [ADAPT/Standard] Does Data Type Representation indeed need a Version? (Issue #108)

https://github.com/zwing99

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.


@zwing99 has proposed that we version the entire collection of Representations using semantic versioning. As such, we would carry a single Representation version number across the entire Application Data Model. Data consumers would simply reference the appropriate version of the codes. As such, we could remove the version from each Representatation. @strheahttps://github.com/strhea and I like the solution. @aferreyrahttps://github.com/aferreyra what are your thoughts?

Yes, please version them as one!

— Reply to this email directly, view it on GitHubhttps://github.com/ADAPT/Standard/issues/108#issuecomment-1727855635, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACGW26AOW64LCXIGXTP4JF3X3L5DPANCNFSM6AAAAAA2RU3QX4. You are receiving this because you were mentioned.Message ID: @.***>

This message may contain confidential information. If you are not the designated recipient, please notify the sender immediately, and delete the original and any copies. Any use of the message by you is prohibited.

knelson-farmbeltnorth commented 1 year ago

As a recommendation, I've attached a Data Type Representation Version to the Root of the model, with the definition "Version identifier of the Data Type Representations used throughout the model. If omitted, the current version is assumed."

image
strhea commented 1 year ago

Works for me!

knelson-farmbeltnorth commented 1 year ago

Agreement in 27 September 2023 meeting to implement as proposed, as well as implementing a similar attribute for Unit System version.