search

ADSD-SoC-FPGA / Code

3 stars 11 forks source link

Modernize TPA6130A2 driver #13

Open LRitzdorf opened 6 months ago

LRitzdorf commented 6 months ago

This PR reimplements the TPA6130A2 (headphone amplifier) driver, following the style of @tvannoy's minimal AD1939 driver.

As noted in #10, the old module was incorrectly named tpa613a2 — that chip does exist, but it lacks an I2C control interface. As part of this rewrite, all such mis-namings have been fixed. As an added bonus, this might make issue diagnostics a bit easier; if students see errors referencing the old name, we'll know they haven't properly migrated to the new driver.

Also, this PR doesn't implement the "mute upon module unload" behavior discussed in #10 — that's probably best reserved for a different PR.

Resolves #10

LRitzdorf commented 6 months ago

Also, this has been tested and is functional (on my system, at least). Further testing is welcome!

LRitzdorf commented 6 months ago

@tvannoy @rksnider Ping, in case one of you would like to review this

tvannoy commented 6 months ago

Ross and I generally operate as JIT compilers, so we'll get around to it closer to next spring. I'm teaching the class in the fall, so I might have time to get around to this in the fall.

LRitzdorf commented 6 months ago

In that case, I'll also rebase #11 on top of this — that way, they can be merged in sequence once (if?) you're ready. Thanks for letting me know!