search

ADSP-EcoTrekker-Project / EcoTrekker

3 stars 1 forks source link

Move Models Classes to common project #44

Closed Andy3189 closed 6 months ago

arslanerdemm commented 8 months ago
Andy3189 commented 8 months ago

  • model classes

    • exception handling

Exception handling should be handled separately no?

lierseleow commented 8 months ago

There is also an argument to be made that the model classes should not be shared, so that service specific additional methods / fields are not impacted. This could be handled by making subclasses that inherit from the shared model. But that may also negatively impact services down the line.

arslanerdemm commented 8 months ago

  • model classes

    • exception handling

Exception handling should be handled separately no?

we're going to need few of those exceptionhandlings in every service i'd say https://github.com/ADSP-EcoTrekker-Project/EcoTrekker/blob/main/rest-api/src/main/java/com/ecotrekker/restapi/exception/GlobalExceptionHandler.java