ADefWebserver / ADefWebserver.Module.HtmlTextV2

MIT License
3 stars 1 forks source link

[ENH] File Manager Integration #8

Open thabaum opened 3 weeks ago

thabaum commented 3 weeks ago

The Oqtane Framework File Manager will need to be integrated, enhanced and tested for inserting document/media/image files.

ADefWebserver commented 3 weeks ago

Can't we just use the existing endpoint that the current core HTML module uses? Meaning, do not implement our own API endpoint. We could even disable the Radzen HTML upload popup if needed. This way if the core makes a security fix on the upload API it would automatically apply to this module too.

thabaum commented 3 weeks ago

I agree with utilizing the API from the core as much as we can, and enhance it as needed to meet our needs with some enhancement requests.

I am curious if we can make a better file manager that has one that looks like the upload picker while we are poking around here... while using the current API. I mean that is the point of Oqtane is to be able to write apps like this.

I do feel simple solution to view files should work to retrieve data securely that a user is allowed. We need to use best practices here. I am just thinking outside the box a little as it may bring on new enhancements to the framework itself to allow all of this to happen.

thabaum commented 3 weeks ago

Possible Idea:

image

integrate the file manager as a component here put the configured file manager component here: image Add: image

image

ADefWebserver commented 3 weeks ago

All great ideas and I agree with you I just want to get a version out, that works, that just meets the minimal requirements :)

thabaum commented 3 weeks ago

I hope we can release with a future proof version best we can taking in all ideas as they come. Again this will be installable but needs to give a real reason to support or becomes uninstallable. If we can't make this work, who can?!

thabaum commented 3 weeks ago

As for this POC i just want to see it work with saving content and switching between design and source modes as expected in all render modes that can be chosen today in Oqtane. The file manager can stay same but I feel it can possibly be enhanced further with not a lot of effort.

I am grinding my way there, might have something sooner than later I am hoping. 🚀 🌔

thabaum commented 3 weeks ago

When I say use the file manager I am saying put the UI component in that location. It is already created, use it and replace the other one that just has logic for an upload. Either way I am open to for now for sure ;)

ADefWebserver commented 3 weeks ago

When I say use the file manager I am saying put the UI component in that location. It is already created, use it and replace the other one that just has logic for an upload.

Ok sounds good 👍🏽

thabaum commented 2 weeks ago

image

This is what I am proposing we think about doctoring up with the file manager.

Not exactly, but a modified version of this that is simple to understand. The buttons "Insert Image" and "Close" can be removed... and the flow of the file manager may need modified. It would be nice if this works with inserting in source and designer modes.

Updated Screenshots:

image

image

ADefWebserver commented 2 weeks ago

It looks great, but, I think it is a lot of work to deal with all the "issues" (security, features, ect.)