AElfProject / AElf

An AI-enhanced cloud-native layer-1 blockchain network. 
https://aelf.com/
MIT License
1.61k stars 264 forks source link

Transaction status result optimization #3625

Open JimAelf opened 5 days ago

JimAelf commented 5 days ago

The Status is obsolete in this version. Use StatusV2 instead. For issue #3623

vizipi[bot] commented 5 days ago

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code. This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00% jason-hoopox 16 3
66.67% ZhangXin 14 2
66.67% eanzhao 13 2
33.33% gldeng 5 1
33.33% chopin.fan 2 1
33.33% zhifenglee-portkey 1 1

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
protobuf/kernel.proto75.00%9 out of 12 times

Committed file ranks

  • 77.60%[...src/AElf.WebApp.Application.Chain/Dto/TransactionResultDt]
  • 93.86%[...src/AElf.WebApp.Application.Chain/Services/TransactionRes]
  • 98.54%[protobuf/aelf/core.proto]
  • codecov[bot] commented 5 days ago

    Codecov Report

    All modified and coverable lines are covered by tests :white_check_mark:

    Project coverage is 73.44%. Comparing base (88d4e10) to head (39398fa). Report is 30 commits behind head on dev.

    :exclamation: There is a different number of reports uploaded between BASE (88d4e10) and HEAD (39398fa). Click for more details.

    HEAD has 22 uploads less than BASE | Flag | BASE (88d4e10) | HEAD (39398fa) | |------|------|------| ||31|9|
    Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/AElfProject/AElf/pull/3625/graphs/tree.svg?width=650&height=150&src=pr&token=X07fSKQJPV&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AElfProject)](https://app.codecov.io/gh/AElfProject/AElf/pull/3625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AElfProject) ```diff @@ Coverage Diff @@ ## dev #3625 +/- ## =========================================== - Coverage 90.53% 73.44% -17.10% =========================================== Files 677 678 +1 Lines 26104 26424 +320 Branches 2353 2440 +87 =========================================== - Hits 23634 19406 -4228 - Misses 2355 6859 +4504 - Partials 115 159 +44 ``` | [Flag](https://app.codecov.io/gh/AElfProject/AElf/pull/3625/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AElfProject) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/AElfProject/AElf/pull/3625/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AElfProject) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AElfProject#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/AElfProject/AElf/pull/3625?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AElfProject) | Coverage Δ | | |---|---|---| | [...tion.Chain/Services/TransactionResultAppService.cs](https://app.codecov.io/gh/AElfProject/AElf/pull/3625?src=pr&el=tree&filepath=src%2FAElf.WebApp.Application.Chain%2FServices%2FTransactionResultAppService.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AElfProject#diff-c3JjL0FFbGYuV2ViQXBwLkFwcGxpY2F0aW9uLkNoYWluL1NlcnZpY2VzL1RyYW5zYWN0aW9uUmVzdWx0QXBwU2VydmljZS5jcw==) | `0.00% <ø> (-100.00%)` | :arrow_down: | ... and [154 files with indirect coverage changes](https://app.codecov.io/gh/AElfProject/AElf/pull/3625/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AElfProject)