Enable cluster and workload creation on A3+.

AI-Hypercomputer / xpk

xpk (Accelerated Processing Kit, pronounced x-p-k,) is a software tool to help Cloud developers to orchestrate training jobs on accelerators such as TPUs and GPUs on GKE.

Apache License 2.0

70 stars 18 forks source link

Enable cluster and workload creation on A3+. #145

Closed yangyuwei closed 4 months ago

yangyuwei commented 4 months ago

Fixes / Features

remove nccl plugin installation in workload creation on A3
enable cluster and workload creation on A3+

Testing / Documentation

Manual tests passed for cluster creation and workload creation on A3+.

[ y ] Tests pass
[ y ] Appropriate changes to documentation are included in the PR

yangyuwei commented 4 months ago

LGTM overall! Just some small requests

Thanks for the review! I've updated the code based on your comments in the latest commit (https://github.com/google/xpk/commit/091edf65ba29b6311c098665d911527b314ec60f). PTAL.