search

AICoE / prometheus-anomaly-detector

A newer more updated version of the prometheus anomaly detector (https://github.com/AICoE/prometheus-anomaly-detector-legacy)
GNU General Public License v3.0
596 stars 150 forks source link

added sensitivity option for PAD #159

Closed saswat0 closed 2 years ago

saswat0 commented 3 years ago

This parameter will help in manipulating the sensitivity of the anomaly detection logic

saswat0 commented 3 years ago

Thanks for the tip! @chauhankaranraj 😄 I didn't expect metric values to be negative and hence the notion of yhat_lower going negative didn't strike me either. Thank you for pointing that out! (Your proposed method is indeed elegant 😉) I've made the changes in the PR

chauhankaranraj commented 3 years ago

Thanks for the tip! @chauhankaranraj I didn't expect metric values to be negative and hence the notion of yhat_lower going negative didn't strike me either. Thank you for pointing that out! (Your proposed method is indeed elegant ) I've made the changes in the PR

Thanks, the changes look good to me :smile: Could you please squash the two commits into one? /lgtm

saswat0 commented 3 years ago

@chauhankaranraj I've squashed the commits into one ✌️😄

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 4n4nd, chauhankaranraj

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/AICoE/prometheus-anomaly-detector/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
4n4nd commented 3 years ago

/test pre-commit

sesheta commented 3 years ago

@4n4nd: No presubmit jobs available for AICoE/prometheus-anomaly-detector@master

In response to [this](https://github.com/AICoE/prometheus-anomaly-detector/pull/159#issuecomment-927507537): >/test pre-commit Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
4n4nd commented 3 years ago

/retest

sesheta commented 2 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

afirth commented 2 years ago

Poke? <3 /remove-lifecycle stale

chauhankaranraj commented 2 years ago

/retest

sesheta commented 2 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

saswat0 commented 2 years ago

/remove-lifecycle stale

sesheta commented 2 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

sesheta commented 2 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

sesheta commented 2 years ago

@sesheta: Closed this PR.

In response to [this](https://github.com/AICoE/prometheus-anomaly-detector/pull/159#issuecomment-1147764938): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.