search

AIM-Harvard / SlicerRadiomics

A Slicer extension to provide a GUI around pyradiomics
BSD 3-Clause "New" or "Revised" License
104 stars 48 forks source link

ENH: Update CLI definition #46

Closed JoostJM closed 6 years ago

JoostJM commented 6 years ago

Remove use .bat and .sh wrapper script, and instead define the CLI entry point as a python script. This makes use of the new Slicer functionality described in Slicer#894 and implemented in r27143-r27145.

This fixes #43.

Additionally, check if a --label <label> argument is present, and if so, update it to the new-style: --setting=label:<label>. Parameter --label is deprecated by PR PyRadiomics#347.

New functionality has been verified to work on Windows. @fedorov, can you test if this works on mac?

cc @Radiomics/developers

TODO:

fedorov commented 6 years ago

I am testing on mac

fedorov commented 6 years ago

Sorry for the delay - confirmed it works on mac. I am going to merge this.