search

AIS-22 / UNI-AIS-BiometricSystems

1 stars 0 forks source link

Adapt linter #12

Closed HafnerMichael closed 1 year ago

HafnerMichael commented 1 year ago

Description

Use flake8 as linter to also check the naming conventions

m-langer commented 1 year ago

Can this linter do everything or should we just leave both of them in there?

HafnerMichael commented 1 year ago

Can this linter do everything or should we just leave both of them in there?

There is no need because flake uses pycodestyle internally see here

m-langer commented 1 year ago

Alright. Then the only fix I can see is the problem of the linter.

sfindenig commented 1 year ago

Since the abstract classifier is blocking this pr anyway, add this here, or postpone this pr and rebase it once the abstract classifier is fixed?

HafnerMichael commented 1 year ago

I would suggest to merge it, we just introduce a new functionality and from now on the repo follows those coding conventions. If you want to stick on the gh worklfow we can create a issue and resolve it in combination with #9