search

AMICI-dev / AMICI

Advanced Multilanguage Interface to CVODES and IDAS
https://amici.readthedocs.io/
Other
111 stars 31 forks source link

GHA: Workaround for macos segfaults #2572

Closed dweindl closed 3 weeks ago

dweindl commented 3 weeks ago

Homebrew serves swig 4.3.0 which is incompatible with filterwarnings = error in pytest resulting in segfaults (#2565, https://github.com/swig/swig/issues/3061). For now, the easiest workaround seems to be just ignoring any warnings during macos runs.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.71%. Comparing base (ff6b3f1) to head (7b353a4). Report is 1 commits behind head on develop.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2572/graphs/tree.svg?width=650&height=150&src=pr&token=1bt9lbspzk&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev)](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2572?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) ```diff @@ Coverage Diff @@ ## develop #2572 +/- ## =========================================== - Coverage 77.75% 77.71% -0.05% =========================================== Files 325 325 Lines 21857 21857 Branches 1473 1473 =========================================== - Hits 16996 16986 -10 - Misses 4834 4844 +10 Partials 27 27 ``` | [Flag](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2572/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2572/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `73.58% <ø> (-0.05%)` | :arrow_down: | | [cpp_python](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2572/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `34.20% <ø> (ø)` | | | [petab](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2572/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `37.07% <ø> (ø)` | | | [python](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2572/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `72.36% <ø> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1 file with indirect coverage changes](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2572/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev)
dweindl commented 3 weeks ago

For now, the easiest workaround seems to be just ignoring any warnings during macos runs.

If this does not get fixed soon, we need to modify the swig-generated cpp files (base + model) to undefine SWIG_HEAPTYPES.