search

AMICI-dev / AMICI

Advanced Multilanguage Interface to CVODES and IDAS
https://amici.readthedocs.io/
Other
111 stars 31 forks source link

Add missing fields in ExpData HDF5 I/O #2593

Closed dweindl closed 5 days ago

dweindl commented 6 days ago

Closes #2589

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 31.14754% with 42 lines in your changes missing coverage. Please review.

Project coverage is 77.50%. Comparing base (7ba2165) to head (c0b161d). Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/hdf5.cpp 31.14% 42 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2593/graphs/tree.svg?width=650&height=150&src=pr&token=1bt9lbspzk&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev)](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) ```diff @@ Coverage Diff @@ ## develop #2593 +/- ## =========================================== - Coverage 77.63% 77.50% -0.13% =========================================== Files 329 329 Lines 22061 22122 +61 Branches 1456 1474 +18 =========================================== + Hits 17126 17145 +19 - Misses 4924 4966 +42 Partials 11 11 ``` | [Flag](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2593/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2593/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `73.44% <31.14%> (-0.12%)` | :arrow_down: | | [cpp_python](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2593/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `34.20% <0.00%> (-0.10%)` | :arrow_down: | | [petab](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2593/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `37.09% <0.00%> (-0.15%)` | :arrow_down: | | [python](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2593/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | `72.20% <6.66%> (-0.19%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2593?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev) | Coverage Δ | | |---|---|---| | [src/hdf5.cpp](https://app.codecov.io/gh/AMICI-dev/AMICI/pull/2593?src=pr&el=tree&filepath=src%2Fhdf5.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AMICI-dev#diff-c3JjL2hkZjUuY3Bw) | `84.48% <31.14%> (-4.53%)` | :arrow_down: |

🚨 Try these New Features: