Fix roundoff issue in SUNDIALS evolve() - Githubissues

AMReX-Codes / amrex

AMReX: Software Framework for Block Structured AMR

https://amrex-codes.github.io/amrex

Other

553 stars 352 forks source link

Fix roundoff issue in SUNDIALS evolve() #4148

Closed ajnonaka closed 2 months ago

ajnonaka commented 2 months ago

Summary

Fix a roundoff issue in the SUNDIALS evolve() function that caused the integrator to run a second time with a very tiny dt in a given time step.

Additional background

Checklist

The proposed changes:

[X ] fix a bug or incorrect behavior in AMReX
[ ] add new capabilities to AMReX
[ ] changes answers in the test suite to more than roundoff level
[ ] are likely to significantly affect the results of downstream AMReX users
[ ] include documentation in the code and/or rst files, if appropriate

WeiqunZhang commented 2 months ago

Any reasons why std::abs is needed? Also the last argument should be an int (e.g., 10, not double like 10..

ajnonaka commented 2 months ago

@WeiqunZhang fixed