namespace - Githubissues

AMReX-Microelectronics / FerroX

FerroX is a massively parallel, 3D phase-field simulation framework for modeling ferroelectric materials based scalable logic devices.

Other

9 stars 9 forks source link

namespace #21

Closed prkkumar closed 1 year ago

prkkumar commented 1 year ago

This PR addresses issue #18

Moved all parsed input parameters to a namespace
Modified all function signatures and calls to use global variables from namespace rather than passing them as input parameters

prkkumar commented 1 year ago

Testing done! Compared this PR with development

input file used : input.txt

Color plot of Pz:

./ComparePlotfiles3d.gnu.ex infile1 = plt00001000/ reffile = namespace/plt00001000/

AMReX (21.08-577-ge4ab0485621d-dirty) initialized
ncomp = 11
nodality (0,0,0)
npts in coarse domain = 73728
npts in fine   domain = 73728
ref_ratio = 1
(comp,L0,L1,L2) 0 0 0 0 
(comp,L0,L1,L2) 1 0 0 0 
(comp,L0,L1,L2) 2 0 0 0 
(comp,L0,L1,L2) 3 0 0 0 
(comp,L0,L1,L2) 4 0 0 0 
(comp,L0,L1,L2) 5 0 0 0 
(comp,L0,L1,L2) 6 0 0 0 
(comp,L0,L1,L2) 7 0 0 0 
(comp,L0,L1,L2) 8 0 0 0 
(comp,L0,L1,L2) 9 0 0 0 
(comp,L0,L1,L2) 10 0 0 0 
AMReX (21.08-577-ge4ab0485621d-dirty) finalized

prkkumar commented 1 year ago

Tested again after cleanup. Diffs remain similar

AMReX (21.08-577-ge4ab0485621d-dirty) initialized
ncomp = 11
nodality (0,0,0)
npts in coarse domain = 73728
npts in fine   domain = 73728
ref_ratio = 1
(comp,L0,L1,L2) 0 0 0 0 
(comp,L0,L1,L2) 1 0 0 0 
(comp,L0,L1,L2) 2 8.992806499e-15 9.143284679e-16 1.784646461e-15 
(comp,L0,L1,L2) 3 1.668110094e-14 3.223858307e-15 4.530287118e-15 
(comp,L0,L1,L2) 4 0.003675743937 0.0001605984699 0.0004809868636 
(comp,L0,L1,L2) 5 1.004338264e-05 1.98066506e-06 2.751780343e-06 
(comp,L0,L1,L2) 6 0 0 0 
(comp,L0,L1,L2) 7 7.204711437e-06 1.553830992e-06 1.939722809e-06 
(comp,L0,L1,L2) 8 0 0 0 
(comp,L0,L1,L2) 9 0 0 0 
(comp,L0,L1,L2) 10 0 0 0 
AMReX (21.08-577-ge4ab0485621d-dirty) finalized

prkkumar commented 1 year ago

@ajnonaka It can be merged now