ANTsX / ANTs

Advanced Normalization Tools (ANTs)
Apache License 2.0
1.19k stars 380 forks source link

BUG: Manifold parzen windows. #1757

Closed ntustison closed 3 months ago

ntustison commented 3 months ago

Addresses https://github.com/ANTsX/ANTs/issues/1664.

The different likelihood functions (e.g., Gaussian, ManifoldParzenWindows) are generated from a list of samples. For example, in the classic three tissue scenario, the voxels labeled as 'CSF' for the current iteration are fed into the first likelihood function which are used to estimate the likelihood function parameters (e.g., Gaussian mean). When I first wrote this, once these parameters were estimated, the samples were no longer needed so I wrote a function to clear the input sample list immediately after likelihood parameter estimation. However, this is no longer the case with the ManifoldParzenWindows, which relies on the Kdtree class which apparently needs to know the size of the input sample list during evaluation. This pull request removes the deletion of the input list sample after parameter estimation.

cookpa commented 3 months ago

Thanks @ntustison !