search

ANUSF / ADAUsers

The ADA user management server.
MIT License
4 stars 0 forks source link

Separate 'show' method from OpenID discovery in UsersController #36

Closed odf closed 13 years ago

odf commented 13 years ago

The UsersController#show currently does two very separate things, displaying user details if used interactively and pointing to an xrds page with service information when used during OpenID discovery. This leads to strange errors and complicated code, so we should use a separate method 'discover' or 'openid' for this purpose. Maybe it would be even better to use a separate controller for OpenID-related actions?

steve-hassan commented 13 years ago

Btw, I catch errors using the request.getParameter("openid.error") method or any thrown exception.

Also, for rare cases when the OpenID session is still active but the Nesstar session is inactive, I will need the URL of the logout servlet. E.g i use

Please <a href="<%=OPENID_URL%>/logout.jsp?return_url=<%=url%>">Logout</a> first.

So would it be possible to pass a return url to the logout to bounce back to?

odf commented 13 years ago

Steve: you should be able to do the except same thing, just with /logout instead of /logout.jsp. I've modelled the logout process on what you did for joid, including the return_url parameter.

odf commented 13 years ago

The change was made a while ago and seems to work fine.