search

AOSPAlliance / android-prepare-vendor

Set of scripts to automate AOSP compatible vendor blobs generation from factory images
25 stars 8 forks source link

Add API29 full config for sargo #17

Closed CaseyBakey closed 4 years ago

CaseyBakey commented 4 years ago

Add API29 full config for sargo

chirayudesai commented 4 years ago

I'm not sure if we want to merge this at this point, especially given that it's only for one device, and includes Google apps.

Previous full configs included some bits from what you added but not google apps from what I can tell, since one can't actually ship them anyway.

CaseyBakey commented 4 years ago

As said in the README.md: "On the other hand the full configuration group (enabled with -f|--full flag from master script) has additional blobs & module targets which are normally marked as non-essential, although might be required for some carriers or in case of GApps being installed (either manually post-boot or included as additional vendor blobs)."

So the whole point of the "full" configurations was always to allow for Google Apps inclusion.

And I didn't add any new Google Apps: I based my "work" on the API-28 "full" configuration for the sargo device where you can find some Google Apps already included. It's just that some paths were moved between system/product/vendor partitions.

It's only for one device since this is the one I have and can test on right now. Other people will be able to do the same for other devices they own.

To be honest, I didn't expect to have my first PR ever, be rejected like that since this PR does what it says; add support of the README.md-detailed "full" configuration, for API-29, on sargo device.

I did this because I need to be able to include Google Apps if the user wants to, in my https://github.com/CaseyBakey/chaosp project.

To be able to add Google Apps, thanks to opengapps/aosp_build project, we first need to have a working "full" configuration for the right device/API.

chirayudesai commented 4 years ago

Also, we didn't add full configs here because none of the current users use it.

Happy to include proper full configs otherwise, if you want to add sargo could you add bonito too? Since they're the exact same device it'd be better to keep them in sync.

Others can pick to other devices later depending on what they can test.

Another note is that we're moving off config.json entirely - see https://github.com/AOSPAlliance/android-prepare-vendor/issues/15

We can still have the naked and full configs this way too, in fact the full config could just be the upstream lineage config (plus any minor additions if needed) since they do include most of this stuff.

I myself use a semi-full config but maintain it downstream instead (since we ship with microG but not full google apps, but can still use some of their apps)

CaseyBakey commented 4 years ago

Yes, I can also add it to bonito if you say they're the same.

I will also be able to do it for blueline once I finish a successful CHAOSP build for the sargo device. I can also have access to this device.

I know that not a lot of people are using this project, and less are using the "full" configuration but it is still useful for some so I would be glad for it to stay/to be added since it doesn't interfere with the "naked" configurations.

I didn't know that you were moving from config.json files, I'll take a look on this issue.

But it seems you're teaching me a lot on the "Lineage" fact: I didn't know they were maintening such config. Do you have a link for me to check on it?

I'm also curious about you semi-full config.

I'm myself targeting "pico" config of opengapps in a first try and if everyting is working as intended on Android 10, move to microG too.

CaseyBakey commented 4 years ago

Ok the changes are done (but take a look at my answer here (https://github.com/AOSPAlliance/android-prepare-vendor/pull/17#discussion_r488047071).

I also added bonito but I have to trust you for this one :p

chirayudesai commented 4 years ago

Yes, I can also add it to bonito if you say they're the same.

They are! If you compare the configs, you'll find that the only change is in the name.

I will also be able to do it for blueline once I finish a successful CHAOSP build for the sargo device. I can also have access to this device.

Do it for crosshatch too when you test blueline, same situation there.

I know that not a lot of people are using this project, and less are using the "full" configuration but it is still useful for some so I would be glad for it to stay/to be added since it doesn't interfere with the "naked" configurations.

For sure. If you're testing and using it, we're happy to accept your PRs.

I didn't know that you were moving from config.json files, I'll take a look on this issue.

But it seems you're teaching me a lot on the "Lineage" fact: I didn't know they were maintening such config. Do you have a link for me to check on it?

The issue has links to the lineage configs, and also all other details.

I'm also curious about you semi-full config.

https://gitlab.com/calyxos/vendor_android-prepare-vendor/-/commits/android10

eSIM support is one of the big changes right now, but I was going to add CarrierConfig and friends as needed later.

I'm myself targeting "pico" config of opengapps in a first try and if everyting is working as intended on Android 10, move to microG too.

chirayudesai commented 4 years ago

List seems ok, looks like it matches API 28, thanks!

Could you squash the fixup commits into the original? Ok to have one for sargo and one for bonito

CaseyBakey commented 4 years ago

So I didn't know how to squash commits...

I put each device changes in a branch, and I reset my master (--hard) to yours, then "git push -f" to my fork repo so it seems it auto-closed this PR.

I did create 2 PR, one for each device.

Now, I'll only work on branches :o