APDevTeam / Movecraft

The original movement plugin for Paper. Reloaded. Again.
GNU General Public License v3.0
123 stars 79 forks source link

[Feature / Cleanup] Sign rework (WIP) #679

Open DerToaster98 opened 4 months ago

DerToaster98 commented 4 months ago

Describe in detail what your pull request accomplishes

This PR is a attempt at redoing signs in a more organized way. That encompasses the following things:

TODO List:

Checklist

TylerS1066 commented 3 months ago
  * [ ]  **NEW** Subcraft Move

This would be best left for a separate PR. I believe there are many assumptions that Subcrafts never move, so we'll have to do a through review of the codebase for that feature.

DerToaster98 commented 3 months ago
  * [ ]  **NEW** Subcraft Move

This would be best left for a separate PR. I believe there are many assumptions that Subcrafts never move, so we'll have to do a through review of the codebase for that feature.

Alright, i will remove that from the todo list. Will implement the other points nonetheless

DerToaster98 commented 3 months ago

I've not gotten even an understanding of how this PR works yet, but I have a few comments on the first few files I've looked through.

Github says there are still open reviews, i can't see them though. I will now try to fix the merge conflicts.

After that this PR is ready for testing and approval