Open DerToaster98 opened 4 months ago
* [ ] **NEW** Subcraft Move
This would be best left for a separate PR. I believe there are many assumptions that Subcrafts never move, so we'll have to do a through review of the codebase for that feature.
* [ ] **NEW** Subcraft Move
This would be best left for a separate PR. I believe there are many assumptions that Subcrafts never move, so we'll have to do a through review of the codebase for that feature.
Alright, i will remove that from the todo list. Will implement the other points nonetheless
I've not gotten even an understanding of how this PR works yet, but I have a few comments on the first few files I've looked through.
Github says there are still open reviews, i can't see them though. I will now try to fix the merge conflicts.
After that this PR is ready for testing and approval
Describe in detail what your pull request accomplishes
This PR is a attempt at redoing signs in a more organized way. That encompasses the following things:
TODO List:
[ ] NEW Subcraft MovePostpone for later, this requires thorough analysis priorChecklist