search

ARM-software / tf-issues

Issue tracking for the ARM Trusted Firmware project
37 stars 16 forks source link

RESET_TO_BL31: accepting params #710

Closed ldts closed 2 years ago

ldts commented 2 years ago

Would something like this be acceptable.

Author: Jorge Ramirez-Ortiz jorge@foundries.io Date: 29 minutes ago

bl31: aarch64: RESET_TO_BL31 with parameters

It is not always the case that RESET_TO_BL31 enabled platforms don't execute a
bootloader before BL31. For those use cases, being able to receive arguments
from that first loader (i.e: a DTB) might be a necessary feature.

This code has been validated on iMX8mm.

Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>

diff --git a/bl31/aarch64/bl31_entrypoint.S b/bl31/aarch64/bl31_entrypoint.S index 2d672dd12..4e492bad4 100644 --- a/bl31/aarch64/bl31_entrypoint.S +++ b/bl31/aarch64/bl31_entrypoint.S @@ -67,6 +67,7 @@ func bl31_entrypoint _exception_vectors=runtime_exceptions \ _pie_fixup_size=BL31_LIMIT - BL31_BASE

+#ifndef RESET_TO_BL31_WITH_PARAMS /* ---------------------------------------------------------------------

ldts commented 2 years ago

It has been a while since I contributed to this project and the 'new' process is not quite clear to me (not sure where to send my patch despite having read the docs TBH). thanks,

ssg-bot commented 2 years ago

Hello @ldts!

Thank you for raising an issue for Trusted Firmware-A.

The TF-A project has now migrated to www.trustedfirmware.org. This issue tracker will still remain accessible for some time, but only for historical reasons. From now on you should raise new issues on trustedfirmware.org.

If it is a query or a design discussion it is better discussed via the mailing list. If it is issue/bug which need to be tracked, raise an issue in the issue tracking board and also send an email to the mailing list to notify the TF-A community.

How do I raise issues for TF-A?

Please use our new issue tracking board. For this you just need to login with your existing GitHub account. We also have a guide to help you raise the issue with the appropriate labels and tags. This way it will be easier for both you and us to track and address the issue most effectively.

We are looking forward to seeing you in trustedfirmware.org!

The Trusted Firmware-A team

sandrine-bailleux-arm commented 2 years ago

Hi @ldts ,

It has been a while since I contributed to this project and the 'new' process is not quite clear to me (not sure where to send my patch despite having read the docs TBH).

Please send your patches to this Gerrit server: https://review.trustedfirmware.org

If you need help setting up your environment to contribute patches there, there is some documentation hosted here. Is that the one you went through already? Do you have any specific questions, specific steps you're blocked on or error messages you're getting?

Regards, Sandrine

ldts commented 2 years ago

hi @sandrine-bailleux-arm thanks for coming back to me - yes I had forgotten about setting up gerrit. it is all good now I think

https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/14596

I'll close this issue now