search

ARMmbed / core-util

DEPRECATED: Mbed 3 utilities library
Other
12 stars 17 forks source link

mbed-util does not compile anymore #15

Closed bogdanm closed 9 years ago

bogdanm commented 9 years ago 

c:/work/mbed/mbed-with-minar/mbed-util/mbed-util/atomic_ops.h:76:103: error: explicit qualification in declaration of 'bool mbed::util::atomic_cas(uint8_t_, uint8_t_, uint8_t)'
 bool mbed::util::atomic_cas<uint8_t>(uint8_t *ptr, uint8_t *expectedCurrentValue, uint8_t desiredValue)

c:/work/mbed/mbed-with-minar/mbed-util/mbed-util/atomic_ops.h:89:107: error: explicit qualification in declaration of 'bool mbed::util::atomic_cas(uint16_t_, uint16_t_, uint16_t)'
 bool mbed::util::atomic_cas<uint16_t>(uint16_t *ptr, uint16_t *expectedCurrentValue, uint16_t desiredValue)

c:/work/mbed/mbed-with-minar/mbed-util/mbed-util/atomic_ops.h:102:107: error: explicit qualification in declaration of 'bool mbed::util::atomic_cas(uint32_t_, uint32_t_, uint32_t)'
 bool mbed::util::atomic_cas<uint32_t>(uint32_t *ptr, uint32_t *expectedCurrentValue, uint32_t desiredValue)

[131/140] Building C object source/CMakeFiles/mbed-util.dir/c_/work/mbed/mbed-with-minar/mbed-util/source/mbed-util_mbed.c.o```

Target is frdm-k64f-gcc
How did a change that broke compilation make it to master?
bogdanm commented 9 years ago

Please fix this.

rgrover commented 9 years ago

oops. We don't need the mbed::util:: namespace qualifiers for the following declaration(s). They are already within the namespace scope. armcc hadn't complained. Apologies for breaking the gcc build.

atomic_ops.h:line 108

template<>
bool mbed::util::atomic_cas<uint32_t>(uint32_t *ptr, uint32_t *expectedCurrentValue, uint32_t desiredValue)

I had relocated them from a .cpp file but forgot to remove the qualifiers.