search

ARMmbed / core-util

DEPRECATED: Mbed 3 utilities library
Other
12 stars 17 forks source link

moving Event.h, FunctionPointer*.h, and mbed-sbrk into core-utils; moved out of m… #21

Closed rgrover closed 8 years ago

rgrover commented 8 years ago

…bed-drivers

corresponds with https://github.com/ARMmbed/mbed-drivers/pull/85 This is a first step towards having a POSIX platform. @bogdanm @0xc0170 @bremoran

0xc0170 commented 8 years ago

+1

When we move things like in this PR, the issues related to those files, shall we transfer them ?

bogdanm commented 8 years ago

+1 from me too. We have to be careful abour versioning this and the corresponding changes in other repos. And sure, we can transfer the issues.

0xc0170 commented 8 years ago

We are not yet in 1.x.x, thus this will be version bump minor?

bogdanm commented 8 years ago

Yup, a minor should do the trick I think. One more thing that I've just noticed: FunctionPointer and friends are in their previous mbed namespace, while the classes in core-util are in the mbed::util namespace. We should probably rename that completely to core::util, but for now would you please move the relevant classes to mbed::util? Thanks.

rgrover commented 8 years ago

please hold back on the merge to allow me time to move the sbrk family into core-util. @bremoran

rgrover commented 8 years ago

The move of mbed-sbrk into core-util is ready for review @bogdanm @bremoran @0xc0170

0xc0170 commented 8 years ago

LGTM

bogdanm commented 8 years ago

Looks good!