search

ARMmbed / core-util

DEPRECATED: Mbed 3 utilities library
Other
12 stars 17 forks source link

remove un-necessary include of core_generic.h from PoolAllocator.cpp #22

Closed rgrover closed 8 years ago

rgrover commented 8 years ago

@0xc0170 @bogdanm

bogdanm commented 8 years ago

+1

0xc0170 commented 8 years ago

+1

rgrover commented 8 years ago

bump @0xc0170 @bogdanm

rgrover commented 8 years ago

Guys, i need to push through a bunch of small but unrelated commits leading to the support of Posix backend for minar. I'd like to submit one coherent pull request at a time. Could you please help this process by speeding up the reviews and merge? thanks.

rgrover commented 8 years ago

perhaps I should just submit multiple pull requests to reduce the administrative overheads around merging and publishing.

bogdanm commented 8 years ago

It depends on the type of change. If the set of your PRs leaves some repositories in an un-compilable state until all PRs are merged, it's better to make this clear by specifying the complete list of PRs in the set. If the PRs don't make the code uncompilable (like this one), it's OK to create them one by one (but keep an eye on versioning). I'll merge this PR and update the minor version of the module.

bogdanm commented 8 years ago

Done. Sorry for taking so long on this.