Closed rgrover closed 8 years ago
tested against mbed-drivers using frdm-k64f-gcc. All previously passing tests continue to pass.
Is this just rename? Github shows some changes in files within the same commit :confused: Can we split them into separate PR?
sorry. it seems some changes from my work for the POSIX backend have entered into these PRs. I'll filter them out. The renames made it difficult to compare.
what about namespace rename (mbed::util -> core::util) ?
I'm happy to rename namespace mbed::util to core::util. Please object if I shouldn't.
renaming namespace will cause constant changes to modules which are using for example mbed-client-example will break , also mbed-mesh-api will break. Please re-consider these before you go ahead and change namespacing
what about namespace rename (mbed::util -> core::util) ?
I was in vacation for too long it seems :) When did this happen?
@bogdanm mbed::util -> core::util hasn't happened yet. Based on @yogpan01's comment, might not happen just yet.
@bogdanm mbed::util -> core::util hasn't happened yet. will happen shortly. (today?)
Sorry @rgrover, I wasn't clear. My question was "why do we want to change this?"
@bogdanm it would seem a logical fallout of renaming everything as core-util. But perhaps it isn't necessary.
@bogdanm I am asking if all this rename should also impact namespace in this module to follow, or we are happy with mbed::util for future
@yogpan01 This PR is breaking change already (we should create a label in our repositories to indicate the intention (breaking change) (does not break modules only if they use the feature "extraInclude" (not mbed-util/header_util.h, but header_util.h)
@0xc0170 @yogpan01: This is what sem-ver is for. This will be a minor version bump. All new development will continue in the new minor version. All modules depending on core-util will need to be updated to build cleanly before adopting the new version.
please review @0xc0170 @bogdanm @bremoran
We should see if we can get Jenkins to cover this repo, given all the changes that are active.
+1 @bremoran
@rgrover Can you please update also https://github.com/rgrover/core-util/blob/master/module.json ? I noticed there is still old name used.
@0xc0170 please review
@bogdanm please review
@bogdanm
The loss of Jenkins earlier today meant that we haven't gotten the build triggers for these changes. I've manually triggered a build.
The build failed on all platforms with a missing header file. https://jenkins-internal.mbed.com/job/core-util/3/
I suspect that these are dangling references to repos with PRs already open for this change. I see one failure in minar and one in ualloc
LGTM. The reported build failure should be fixed by a separate PR to MINAR, so I'm going to assume that you compiled locally and everything was fine.
I've compiled locally and run tests from mbed-drivers
+1 then
+1
Published new minor version 0.2.0
@0xc0170 @bogdanm @bremoran