search

ARMmbed / core-util

DEPRECATED: Mbed 3 utilities library
Other
12 stars 17 forks source link

Convert FunctionPointer to use variadic templates #32

Open bremoran opened 8 years ago

bremoran commented 8 years ago

This requires C++11 support. C++11 is currently turned off on mbed. Turning it on manually breaks a lot of things.

This code is tested on my host, but I cannot currently compile it for mbed.

@bogdanm @hugovincent @0xc0170 @salkinium

bogdanm commented 8 years ago

Sorry, I'm a bit confused. If this change requires C++11 and turning it on manually 'breaks a lot of things', why do we think this change is good enough to merge into core-util? I think I'm missing something, but I don't know what.

bremoran commented 8 years ago

Maybe I didn't explain this properly. This code is ready for merge. The targets need to have C++11 enabled and turning on std=c++11 seems to cause some problems in other modules. I made this PR for two reasons:

  1. I don't want us to lose track of it
  2. The code in this PR is done.

I will make a PR to enable C++11 support in target-mbed-gcc/target-mbed-armcc, but we can't merge those until we fix some problems in other modules.

sg- commented 8 years ago

will this make it in before code freeze?

bogdanm commented 8 years ago

No. C++11 will not be enabled for our next release.