search

ARMmbed / core-util

DEPRECATED: Mbed 3 utilities library
Other
12 stars 17 forks source link

Tests for event and function pointer move #36

Closed 0xc0170 closed 8 years ago

0xc0170 commented 8 years ago

As implementations of Event and FunctionPointer were moved to this repo, tests were still in mbed drivers.

I cloned them with the full git history, might be desirable to just reference this history in the commit message (I can squashed this into one commit where the commit message contains this log for both files with commits sha plus reference back to mbed-drivers)

@bogdanm @rgrover @bremoran

0xc0170 commented 8 years ago

bump, tests in this PR were removed from mbed-drivers

bogdanm commented 8 years ago

I see a very long list of commits in this PR, maybe you need to rebase?

0xc0170 commented 8 years ago

I moved the files along with the history, but seems the history here is shown in reversed order. I'll check how to fix that

Update: Ah locally git log shows it correctly

* 2491c4b - (HEAD, origin/dev_test_move, dev_test_move) changes necessary due to rename of core-util::mbed-util/ to core-util/ (22 hours ago* b17cc71 - more changes as FunctionPointer family has moved to new namespace (22 hours ago)
* 5ba6736 - move Event.h, FunctionPointer*.h out of mbed-drivers and into core-utils (22 hours ago)
* 0c929be - update API to pass int argc, char* argv[] to app_start (22 hours ago)
* 79134b8 - update tests for app_start API (22 hours ago)
* ba5b02f - Added FunctionPointer2 and FunctionPointer3 (22 hours ago)
* 09634eb - Restored correct path to Event.h (22 hours ago)
* 0c6374b - Added operator () in Event (22 hours ago)
* b47b097 - Added more tests for the new FunctionPointer/Event implementation (22 hours ago)
* 5e3e943 - Updates to correct code review notes. * Place Event in mbed namespace * Correct handling of bind on FunctionPointer0 * Correct i* 95eb362 - Remove redundant function Add a static assert implementation Remove a memcpy and replace it with copy_args (22 hours ago) <Brend* 5e226de - Experimental changes to add support for placement new. Still requires testing, but tests build and test case works on desktop. (* 66344ba - Added Function Pointers with bound arguments (22 hours ago)
* 3800b82 - changes necessary due to rename of core-util::mbed-util/ to core-util/ (22 hours ago)
* 437a917 - more changes as FunctionPointer family has moved to new namespace (22 hours ago)
* 2d6b3c1 - move Event.h, FunctionPointer*.h out of mbed-drivers and into core-utils (22 hours ago)
* c18216c - update API to pass int argc, char* argv[] to app_start (22 hours ago)
* 7d01fb8 - update tests for app_start API (22 hours ago)
* f146226 - Ported FunctionPointer test to greentea (22 hours ago)
* 32f2617 - Added license to FunctionPointer test (22 hours ago)
* 0e6dd77 - Add some improvements to FunctionPointer. (22 hours ago)
0xc0170 commented 8 years ago

Squashed, added SHA removal commit reference in the commit message.

bogdanm commented 8 years ago

+1