ARMmbed / core-util

DEPRECATED: Mbed 3 utilities library
Other
12 stars 17 forks source link

Replace bind with a version that uses const references #40

Closed bremoran closed 8 years ago

bremoran commented 8 years ago

This version of bind does away with stdarg and uses a friend class instead. This allows FunctionPointer to work with all types of argument, including references.

bremoran commented 8 years ago

cc @bogdanm @niklas-arm @pan- @autopulated

autopulated commented 8 years ago

:thumbsup: looks much nicer, can't see anything obviously wrong – notice we still don't have tests checking the lifetime of argument objects though?

bremoran commented 8 years ago

Yes, we definitely need more extensive testing. I have written some more tests, but they don't go to that depth yet either.

bogdanm commented 8 years ago

I'll try to run the Event test on this change (and maybe automate the test a bit more in the process) since it touches some lifetime aspects, but if there's not enough confidence, it's safer to merge this after the TechCon release.

bremoran commented 8 years ago

Since github hides commit messages by default, here's the message from the previous commit:

bremoran commented 8 years ago

Bump for review

bogdanm commented 8 years ago

Looks good. Let's merge it and check if anything breaks.