Closed bremoran closed 8 years ago
cc @bogdanm @niklas-arm @pan- @autopulated
:thumbsup: looks much nicer, can't see anything obviously wrong – notice we still don't have tests checking the lifetime of argument objects though?
Yes, we definitely need more extensive testing. I have written some more tests, but they don't go to that depth yet either.
I'll try to run the Event test on this change (and maybe automate the test a bit more in the process) since it touches some lifetime aspects, but if there's not enough confidence, it's safer to merge this after the TechCon release.
Since github hides commit messages by default, here's the message from the previous commit:
operator()
to call()
since this introduces one additional copy of each argument.Bump for review
Looks good. Let's merge it and check if anything breaks.
This version of bind does away with stdarg and uses a friend class instead. This allows FunctionPointer to work with all types of argument, including references.