Fix CriticalSectionLock class on Nordic platform.

ARMmbed / core-util

DEPRECATED: Mbed 3 utilities library

Other

12 stars 17 forks source link

Closed pan- closed 8 years ago

pan- commented 8 years ago

Previously, the CriticalSectionLock on Nordic platform was only working if the soft device was running and the interrupts enabled.

Otherwise if the soft device was not running:

If the interrupts were enabled, the CriticalSectionLock didn't work as intented (not disabling interrupts).
If the interrupts were disabled, the construction of CriticalSectionLock instances ended into an Hard fault.

This change require the merge of https://github.com/ARMmbed/mbed-hal-nrf51822-mcu/pull/34 otherwise, once minar will try to go to sleep with the soft device not running, it will end by an Hard fault.

@rgrover

rgrover commented 8 years ago

please use 4-bytes of indentation

rgrover commented 8 years ago

this code has now become hard to read could you please consider adding comments?

pan- commented 8 years ago

I tries to add comments in the constructor, is it not enough ?

There should be something in HAL to do this, it is a unfortunate that there is platform dependent code in core-util.

For the indentation, I keeped the indentation used of this file, do I need to change it ?

pan- commented 8 years ago

@rgrover could you comment ?

rgrover commented 8 years ago

this looks good to me. I can merge this change, but I can't make a new release of core-util.

rgrover commented 8 years ago

please involve one of the maintainers of core-util in this review so that they can approve and publish

0xc0170 commented 8 years ago

please use 4-bytes of indentation

Waiting for an update.