Closed pan- closed 8 years ago
please use 4-bytes of indentation
this code has now become hard to read could you please consider adding comments?
I tries to add comments in the constructor, is it not enough ?
There should be something in HAL to do this, it is a unfortunate that there is platform dependent code in core-util.
For the indentation, I keeped the indentation used of this file, do I need to change it ?
@rgrover could you comment ?
this looks good to me. I can merge this change, but I can't make a new release of core-util.
please involve one of the maintainers of core-util in this review so that they can approve and publish
please use 4-bytes of indentation
Waiting for an update.
Previously, the CriticalSectionLock on Nordic platform was only working if the soft device was running and the interrupts enabled.
Otherwise if the soft device was not running:
This change require the merge of https://github.com/ARMmbed/mbed-hal-nrf51822-mcu/pull/34 otherwise, once minar will try to go to sleep with the soft device not running, it will end by an Hard fault.
@rgrover