Fix ordering of LD flag in Makefile

ARUP-NGS / BMFtools

Barcoded Molecular Families

MIT License

22 stars 8 forks source link

Fix ordering of LD flag in Makefile #88

Closed brendanofallon closed 8 years ago

brendanofallon commented 8 years ago

On Ubuntu Xenial (gcc 5.4), BMFTools won't compile unless the LD flags are included after the files, otherwise linker errors otherwise. This PR moves the $(LD) variable in the Makefile to later in the command, allowing successful compilation.

dnbaker commented 8 years ago

The change looks good to me and likely explains an error a user on Ubuntu was reporting which I couldn't reproduce on any of 4 servers plus a laptop.

We've been only merging into master after running a lot of large-scale and small-scale tests. This should instead go into the dev branch. If master needs to be updated ASAP, we should rerun the rest suite in BMFTest and ensure it passes before incrementing versions and releases.

dnbaker commented 8 years ago

Thanks for your help!

I've incorporated your changes into dev. This wasn't a clean merge because other changes to the Makefile since master was last updated, but if you work off of dev, merges should be easy in the future.