`iters` has no effect on `fit_circuit_parameters`!

AUTODIAL / AutoEIS

A tool for automated extraction of equivalent circuit models (ECM) from electrochemical impedance spectroscopy (EIS) data

https://autodial.github.io/AutoEIS/

MIT License

33 stars 7 forks source link

`iters` has no effect on `fit_circuit_parameters`! #130

Closed ma-sadeghi closed 2 months ago

ma-sadeghi commented 3 months ago

This is a nasty bug! Essentially, when curve_fit fails to converge using the initial guess p0, it keeps trying using the same p0! Solution: Replace continue with pass.

https://github.com/AUTODIAL/AutoEIS/blob/f15788e63c652434719f2852c89a24e65a436c18/src/autoeis/utils.py#L505-L515