AUTOMATIC1111 / stable-diffusion-webui-extensions

Extension index for stable-diffusion-webui
483 stars 261 forks source link

add chara-searcher #348

Closed NON906 closed 2 months ago

NON906 commented 2 months ago

Info

https://github.com/NON906/chara-searcher

"editing" is added to automatically remove the background. Also, "query" is added to automatically tag images. If they are not appropriate, please be corresponding.

Checklist:

w-e-w commented 2 months ago

some issues


requirements.txt

gradio==3.41.2

https://github.com/NON906/chara-searcher/blob/1316b61637b353fa701078d49803450aaf90a832/requirements.txt#L3

I understand that since you provided standalone mode you put all the requirements inside one single requirements.txt

but this would highly likely cause issues especially gradio==3.41.2

when we eventually upgraded to Gradio 4 or if a user is on an old version of where you are that is not using gradio==3.41.2, your extentions insulation sequence with Force installation of gradio==3.41.2 which will break things

you would have to provide separate installation sequences / requirements for webui and standalone model

my PR should fix this issue

w-e-w commented 2 months ago

I've encountered another issue during installation

but it only happens at the first couple of times when I try to install it and did not happen again after so I'm not sure how to replicate it basically launch.run(f'"{launch.python}" -m mim install mmengine "mmcv>=2.0.0" mmdet') install mmcv for some reason is sometimes it installs mmcv 2.2.0 and oter times 2.1.0 for me 2.2.0 seems to be incompatible with something (I'm not sure what) if this happens it will cause the extension to not work

NON906 commented 2 months ago

Sorry for the inconvenience.

The pull request has been reflected.

I also added version specifications for mmcv and mmdet in the following commits. https://github.com/NON906/chara-searcher/commit/10ce90e908f116c597b32dd2ccef9792f33090a1